Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add JHelioviewer regex #7471

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Conversation

dgarciabriseno
Copy link
Contributor

Description:

Add support for the JHelioviewer user agent.

This application is very niche, it doesn't really fit into any of your existing client categories.

If you would like to test it, a sample user agent looks like "JHV/SWHV-4.4.2.10777 (x86_64 Mac OS X 13.2.1) Eclipse Adoptium JRE 19.0.2"

Review

@liviuconcioiu
Copy link
Collaborator

@dgarciabriseno you also have to add this test, here https://github.com/matomo-org/device-detector/blob/master/Tests/Parser/Client/fixtures/mediaplayer.yml

-
  user_agent: JHV/SWHV-4.4.2.10777 (x86_64 Mac OS X 13.2.1) Eclipse Adoptium JRE 19.0.2
  client:
    type: mediaplayer
    name: JHelioviewer
    version: 4.4.2.10777

@sanchezzzhak sanchezzzhak merged commit baa485b into matomo-org:master Sep 20, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants