Fix Blink detection across many browsers. #7583
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Lots of Blink-based browsers were being incorrectly detected as WebKit. This PR updates the Blink regex in
browser_engines.yml
to use a regex that matches on theChrome/
token for Blink (using versions starting with 29). It also updates several browser definitions that previously referred to WebKit to refer either to Blink or to auto-detect the engine (using an empty string, which appears to be a common thing in the file for some browsers).Most of the changes in this PR are test cases. I updated them in bulk using this Node.js script. Those should be the only changes in the
Tests
directory, and can be reproduced by resetting that directory and re-running the script.Review