Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adds detection for Gmail and Spicebird #7712

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Adds detection for Gmail and Spicebird #7712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc993d9
Adds detection for Spicebird
liviuconcioiu Jun 20, 2024
a451176
Improves detection for Spice brand
liviuconcioiu Jun 20, 2024
c7cc74c
Adds detection for Gmail
liviuconcioiu Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions Tests/Parser/Client/fixtures/pim.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,3 +275,15 @@
type: pim
name: mailapp
version: 6.5.0
-
user_agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.2pre) Gecko/2009031304 Spicebird/0.7.1
client:
type: pim
name: Spicebird
version: 0.7.1
-
user_agent: Android-Gmail/64562652 (sw411dp; 420dpi) (r7 TP1A.220624.014)
client:
type: pim
name: Gmail
version: ""
16 changes: 16 additions & 0 deletions Tests/fixtures/desktop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9727,3 +9727,19 @@
model: Engage One Pro AIO
os_family: Android
browser_family: Chrome
-
user_agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.0.2pre) Gecko/2009031304 Spicebird/0.7.1
os:
name: GNU/Linux
version: ""
platform: x86
client:
type: pim
name: Spicebird
version: 0.7.1
device:
type: desktop
brand: ""
model: ""
os_family: GNU/Linux
browser_family: Unknown
10 changes: 10 additions & 0 deletions regexes/client/pim.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,11 @@
name: 'Thunderbird'
version: '$1'

# Spicebird (http://www.spicebird.org/)
- regex: 'Spicebird/(\d+\.[\.\d]+)'
name: 'Spicebird'
version: '$1'

- regex: 'Airmail(?: (\d+[\.\d]+))?'
name: 'Airmail'
version: '$1'
Expand Down Expand Up @@ -155,3 +160,8 @@
- regex: 'mailapp/(\d+\.[\.\d]+)'
name: 'mailapp'
version: '$1'

# Gmail
- regex: 'Android-Gmail'
name: 'Gmail'
version: ''
2 changes: 1 addition & 1 deletion regexes/device/mobiles.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23793,7 +23793,7 @@ Sigma:

# Spice
Spice:
regex: '(?<![\d];)Spice|(?:Xlife[-_ ](?:\d+Q?|Victor5|M5q\+|M5 Pro|Proton5|Electro55HD))(?:[);/ ]|$)'
regex: '(?<![\d];)Spice(?!bird)|(?:Xlife[-_ ](?:\d+Q?|Victor5|M5q\+|M5 Pro|Proton5|Electro55HD))(?:[);/ ]|$)'
device: 'smartphone'
models:
- regex: '(?:Spice_)?Xlife[-_ ](\d+Q?|M5\+)(?:[);/ ]|$)'
Expand Down
Loading