Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update PHPCS and PHPUnit workflows #7747

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

liviuconcioiu
Copy link
Collaborator

@liviuconcioiu liviuconcioiu commented Jul 18, 2024

Closes #7570

@tacman, @williamdes I've cherry-picked your commits.

@sgiehl I also had to update the phpcs workflow, see https://github.com/matomo-org/device-detector/actions/runs/9998554424/job/27637706999

All tests seem to pass, on the previous draft PR (#7746), but #7727 has to be merged first.

Also, there are a few PHPUnit deprecations starting with PHP 8.2 (https://github.com/matomo-org/device-detector/actions/runs/9998727002/job/27638264245), that should be fixed another time.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants