Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Improves version detection for Brave #7795

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Improves version detection for Brave #7795

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a7a9dd
Improves version detection for Brave
liviuconcioiu Aug 25, 2024
195c894
Merge branch 'master' into brave
sanchezzzhak Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions Tests/Parser/Client/fixtures/browser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9808,3 +9808,12 @@
family: Chrome
headers:
Sec-CH-UA: '"Chromium";v="122", "Not(A:Brand";v="24", "XiaoMiBrowser";v="122"'
-
user_agent: Mozilla/5.0 (Linux; Android 7.0; SM-G920F) AppleWebKit/537.36 (KHTML, like Gecko) Brave Chrome/85.0.4183.121 Mobile Safari/537.36
client:
type: browser
name: Brave
version: 85.0.4183.121
engine: Blink
engine_version: 85.0.4183.121
family: Chrome
2 changes: 1 addition & 1 deletion regexes/client/browsers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1805,7 +1805,7 @@
version: '$1'
engine:
default: 'Blink'
- regex: 'Brave(?:/(\d+[\.\d]+))?'
- regex: 'Brave(?: Chrome)?(?:/(\d+[\.\d]+))?'
name: 'Brave'
version: '$1'
engine:
Expand Down
Loading