Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename Arc to Arc Search and improves detection for Arc Search and Chrome Webview #7908

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Rename Arc to Arc Search and improves detection for Arc Search and Chrome Webview #7908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e960f12
Rename Arc to Arc Search
liviuconcioiu Nov 4, 2024
9b5d289
Improves detection for Arc Search
liviuconcioiu Nov 4, 2024
b093cdb
Improves detection for Chrome Webview
liviuconcioiu Nov 4, 2024
af60858
Merge branch 'master' into browsers
sanchezzzhak Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Parser/Client/Browser.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ class Browser extends AbstractClientParser
'AW' => 'Amiga Aweb',
'PN' => 'APN Browser',
'6A' => 'Arachne',
'RA' => 'Arc',
'RA' => 'Arc Search',
'R5' => 'Armorfly Browser',
'AI' => 'Arvin',
'AK' => 'Ask.com',
Expand Down
26 changes: 24 additions & 2 deletions Tests/Parser/Client/fixtures/browser.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7930,7 +7930,7 @@
user_agent: ArcMobile2/1 CFNetwork/1494.0.5 Darwin/23.4.0
client:
type: browser
name: Arc
name: Arc Search
version: ""
engine: WebKit
engine_version: ""
Expand Down Expand Up @@ -9435,7 +9435,7 @@
user_agent: ArcMobile2/1.3.1; iPhone; iOS 16.1.1; Scale/2.00
client:
type: browser
name: Arc
name: Arc Search
version: 1.3.1
engine: WebKit
engine_version: ""
Expand Down Expand Up @@ -10339,3 +10339,25 @@
engine: Blink
engine_version: 116.0.5845.190
family: Chrome
-
user_agent: Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/130.0.6723.60 Mobile Safari/537.36
client:
type: browser
name: Arc Search
version: ""
engine: Blink
engine_version: 130.0.6723.60
family: Chrome
headers:
http-x-requested-with: company.thebrowser.arc
-
user_agent: Mozilla/5.0 (Linux; Android 10; K) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Mobile Safari/537.36
client:
type: browser
name: Chrome Webview
version: ""
engine: Blink
engine_version: 123.0.0.0
family: Chrome
headers:
http-x-requested-with: com.android.webview
4 changes: 2 additions & 2 deletions regexes/client/browsers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,9 +502,9 @@
engine:
default: 'Blink'

# Arc (https://arc.net/)
# Arc Search (https://arc.net/ | https://arc.net/search)
- regex: 'ArcMobile2(?:/(\d+\.[.\d]+);)?'
name: 'Arc'
name: 'Arc Search'
version: '$1'
engine:
default: 'WebKit'
Expand Down
2 changes: 2 additions & 0 deletions regexes/client/hints/browsers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,3 +322,5 @@
'com.hawk.android.browser': 'Hawk Turbo Browser'
'com.zte.nubrowser': 'ZTE Browser'
'com.cloaktp.browser': 'Privacy Pioneer Browser'
'company.thebrowser.arc': 'Arc Search'
'com.android.webview': 'Chrome Webview'
Loading