Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Ignore empty values for client hints #7949

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Ignore empty values for client hints #7949

merged 1 commit into from
Dec 15, 2024

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 13, 2024

Description:

fixes matomo-org/matomo#22846

Review

@sgiehl sgiehl requested a review from liviuconcioiu December 13, 2024 15:16
@liviuconcioiu liviuconcioiu merged commit fa35190 into master Dec 15, 2024
15 checks passed
@liviuconcioiu liviuconcioiu deleted the ignorenullvalue branch December 15, 2024 09:48
liviuconcioiu added a commit to liviuconcioiu/device-detector that referenced this pull request Dec 15, 2024
@liviuconcioiu
Adds test for null values in client hints
ff9f1ce 
ref matomo-org#7949
@liviuconcioiu liviuconcioiu mentioned this pull request Dec 15, 2024
Merged
sgiehl pushed a commit that referenced this pull request Dec 16, 2024
@liviuconcioiu
Adds test for null values in client hints (#7951)
d5cbfdb 
ref #7949
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@liviuconcioiu liviuconcioiu liviuconcioiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fatal error: Argument #1 ($string) must be of type string in ClientHints.php:285
2 participants
@sgiehl @liviuconcioiu