Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rebrand from Piwik to Matomo #51

Merged
merged 2 commits into from
Jan 1, 2020
Merged

Rebrand from Piwik to Matomo #51

merged 2 commits into from
Jan 1, 2020

Conversation

sgiehl
Copy link
Member

@sgiehl sgiehl commented Dec 9, 2019

Needs to be republished on packagist after merge with the new name, and the old one needs to be marked as Abandoned.

@tsteur
Copy link
Member

tsteur commented Dec 19, 2019

Just a random thought... wondering if it makes sense to have PiwikTracker.php file as well including MatomoTracker.php and then in both PiwikTracker and MatomoTracker class we could have

if (!class_exists(PiwikTRacker)) { . class PiwikTracker extends MatomoTracker }? This way BC works no matter if Piwiktracker file was included or only Matomotracker? Just makes things bit easier even for us as we use PiwikTracker in various places and be great if we give people an easy way to update... otherwise everyone needs to check which file exists and while file should be loaded etc

In Matomo 5 we could then remove PiwikTracker completely (or leave it there if it doesn't cause us any issues)

@sgiehl
Copy link
Member Author

sgiehl commented Dec 30, 2019

@tsteur updated the PR

@tsteur
Copy link
Member

tsteur commented Dec 30, 2019

👍

@sgiehl sgiehl merged commit 06a6b46 into master Jan 1, 2020
@sgiehl sgiehl deleted the rebrand branch January 1, 2020 14:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants