Remove the magic background colour. #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samcunliffe
force-pushed
the
35-background-transparent
branch
from
9419be5 to
cc3ec93
Compare
samcunliffe
force-pushed
the
35-background-transparent
branch
from
cc3ec93 to
23604bf
Compare
samcunliffe
commented
May 3, 2023
| self.axes.set_facecolor(NAPARI_WINDOW_COLOR) | ||
| # changing color of axes background to transparent | ||
| self.canvas.figure.patch.set_facecolor("none") | ||
| self.axes.set_facecolor("none") | ||
|
|
||
| # changing colors of all axes |
There was a problem hiding this comment.
Bit of a napari noob here, but I'd guess that these lines 👇 don't work with light themes.
There was a problem hiding this comment.
Ooh yes, suppose they will not. I hadn't heard of the light theme before, I will open a new issue to test and possibly fix napari-matplotlib with the white theme.
dstansby
approved these changes
May 4, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #35