Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tests to make sure right event is returned when all of the events have the same timestamps - MSC3030 #457

Merged
merged 2 commits into from
Aug 30, 2022

Conversation

MadLittleMods
Copy link
Collaborator

Tests to make sure right event is returned when all of the events have the same timestamps.

Synapse changes: matrix-org/synapse#13658

Part of matrix-org/matrix-spec-proposals#3030

@MadLittleMods MadLittleMods marked this pull request as ready for review August 29, 2022 23:21
@MadLittleMods MadLittleMods requested review from a team as code owners August 29, 2022 23:21
@MadLittleMods MadLittleMods removed the request for review from a team August 29, 2022 23:21
Copy link
Contributor

@squahtx squahtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Co-authored-by: Sean Quah <8349537+squahtx@users.noreply.github.com>
MadLittleMods added a commit to matrix-org/synapse that referenced this pull request Aug 30, 2022
…MSC3030 (#13658)

Discovered while working on #13589 and I had all the messages at the same timestamp in the tests.

Part of matrix-org/matrix-spec-proposals#3030

Complement tests: matrix-org/complement#457
@MadLittleMods MadLittleMods merged commit 46504bb into main Aug 30, 2022
@MadLittleMods MadLittleMods deleted the madlittlemods/handle-same-timestamps-in-msc3030 branch August 30, 2022 19:51
@MadLittleMods
Copy link
Collaborator Author

Thanks for the review @squahtx 🦝

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants