Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

fix radio for theme selection #1368

Merged
merged 1 commit into from
Sep 12, 2017
Merged

fix radio for theme selection #1368

merged 1 commit into from
Sep 12, 2017

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Sep 7, 2017

Signed-off-by: Michael Telatynski 7t3chguy@gmail.com

facebook/react#8575 broke it
normally input value/checked should be dumped to state and read from there but this works instead.

onChange now doesn't fire if you don't pass the value into the checked prop anymore.

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm, we should really make the UserSettingsStore more like a store and reload all the data from the store, but I guess this would involve changing a lot of UserSettings

@dbkr dbkr merged commit d90aa6e into develop Sep 12, 2017
@t3chguy t3chguy deleted the t3chguy/fix_theme branch October 29, 2017 17:23
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants