Add workaround for building Android bindings with supported NDK versions (r23+) #1782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1782 +/- ##
=======================================
Coverage 75.95% 75.95%
=======================================
Files 139 139
Lines 15465 15465
=======================================
Hits 11747 11747
Misses 3718 3718 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
jplatte
reviewed
Apr 17, 2023
jplatte
approved these changes
Apr 17, 2023
jplatte
reviewed
Apr 17, 2023
jplatte
deleted the
fix/jme/android-x86_64-issues-with-supported-ndk-versions
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a temporary workaround to
bindings/matrix-sdk-ffi/build.rswhere we replace a linked library with a version that works fine in Android devices with x86_64 arch. This should let us release working versions of the Rust SDK for Android even while this bug still exists.