Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: Use a released version of vodozemac #3721

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Conversation

poljar
Copy link
Contributor

@poljar poljar commented Jul 17, 2024

No description provided.

@poljar poljar requested a review from a team as a code owner July 17, 2024 14:49
@poljar poljar requested review from bnjbvr and removed request for a team July 17, 2024 14:49
Copy link
Member

@bnjbvr bnjbvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫶

Friends don't let friends use dependencies pinned from git versions.

— Famous anonymous person on the internet

@bnjbvr
Copy link
Member

bnjbvr commented Jul 17, 2024

No updates to the Cargo.lock file, though?

@poljar
Copy link
Contributor Author

poljar commented Jul 17, 2024

No updates to the Cargo.lock file, though?

Forgot to run cargo check. 🥲

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.00%. Comparing base (dd20c37) to head (acd499c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3721      +/-   ##
==========================================
- Coverage   84.01%   84.00%   -0.01%     
==========================================
  Files         260      260              
  Lines       26700    26700              
==========================================
- Hits        22432    22430       -2     
- Misses       4268     4270       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@poljar poljar merged commit 30e95bf into main Jul 17, 2024
39 of 40 checks passed
@poljar poljar deleted the poljar/bump-vodozemac branch July 17, 2024 16:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants