test(send queue): cached thumbnails of unknown dimensions are removed after upload #4260
+176
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we don't know the dimensions of a thumbnail, we still need some dimensions to cache it locally in the cache store, because it's required to send the thumbnail with the send queue. As a result, we default to using 0 for the unknown dimensions.
However, as soon as the thumbnail and file have been uploaded, there's no need to keep the 0-sized thumbnail in the cache; it's more likely the callers will try to retrieve it with actual, realistic sizes later. As a result, remove those locally-cached thumbnails from the cache store after a successful upload, if one of their dimensions was unknown.
Part of #4201