Upgrade ruma #76
Merged
Upgrade ruma #76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Most of these changes could have been done earlier, but due to Rust not warning about deprecated re-exports (rust-lang/rust#47236), I forgot them. Now I removed those deprecated re-exports since the next releases will be breaking change releases anyway (would have been nice to keep the aliases around for a while, but not without deprecation warnings). |
Yeah, one of these days I'll get to fixing that, most of this is left over since we first had only once crate and no |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By the way, you've got a weird mix of one use statement per crate and one use statement per module. And also a mix of matrix_sdk_common imports and crate imports in matrix_sdk_base. You may want to fix that.