-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
MSC2409: Proposal to send typing, presence and receipts to appservices #2409
MSC2409: Proposal to send typing, presence and receipts to appservices #2409
Conversation
bumping this up as it would help out of a ton of mx-puppet-slack users! :) |
I really miss this while using mx-puppet-discord. Typing notifications add so much extra value to a chat! |
It seems to me that it would be worth making appservices opt into receiving EDUs to avoid pushing EDUs to an appservice that doesn't care about them. |
@auscompgeek would be even better if appservices could add a filter to their registration data to filter out anything they don't care about. |
@Half-Shot maybe in general add the filter object to the registration file? That way PDUs could also be filtered. That sounds like it should be a separate MSC, though |
It was one from a while ago, but we dropped at the time as the performance gains from doing so weren't worth it. |
Does it sound worthy to bring that up again, in relation with this MSC, and then leave filtering to, well, the filters? |
Yup. I think it's worth noting that we might need filters, but at this point I think that's a seperate concern. This MSC is facilitating the ability for ASes to recieve EDU traffic, another MSC can handle filtering of that traffic. |
Implementing backend at matrix-org/synapse#8437 (available in 1.22.0) |
mautrix-python impl: mautrix/python@ee74e17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small polish, but overall LGTM!
Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
🔔 This is now entering its final comment period, as per the review above. 🔔 |
The final comment period, with a disposition to merge, as per the review above, is now complete. |
subsequent review addressed concerns, I believe
* Initial proposal commit * Add body of proposal * rename file * finish up MSC * address issues * change key names and add unstable prefix * Clarifications; to-device handling * It's not exactly like sync * Move to-device messages * Copy edu_type behaviour * Add full transaction example * Add implementation notes for to-device cleanup * Use type instead of edu_type to match realities of implementations * Add note to say ephemeral can be omitted. * Improve wording on why we use a seperate array. Co-authored-by: Kevin Cox <kevincox@kevincox.ca> * push_ephemeral -> receive_ephemeral * Fix some typos and clarify EDU room association * Clarify EDU formatting * Explicitly list all event types * Delete to-device events to be moved to a new MSC * Update spec link and fix typo Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> * Add private read receipt rules * Apply suggestions from code review Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> * Wrap lines * Apply suggestions from code review Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com> * Explicitly mention to-device events are not here * Mention the possibility of more granular filtering --------- Co-authored-by: Will Hunt <will@half-shot.uk> Co-authored-by: Travis Ralston <travisr@matrix.org> Co-authored-by: Kevin Cox <kevincox@kevincox.ca> Co-authored-by: Tulir Asokan <tulir@maunium.net> Co-authored-by: Patrick Cloke <clokep@users.noreply.github.com> Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com> Co-authored-by: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
spec PR: matrix-org/matrix-spec#2018 |
merged! |
Rendered
This MSC is a continuation of MSC1888 and thus deprecates it.
Implementations:
Signed-off-by: Sorunome mail@sorunome.de
FCP tickyboxes