Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Imported server bans cannot be !unbanned #220

Closed
heftig opened this issue Feb 9, 2022 · 0 comments · Fixed by #227
Closed

Imported server bans cannot be !unbanned #220

heftig opened this issue Feb 9, 2022 · 0 comments · Fixed by #227
Assignees

Comments

@heftig
Copy link

heftig commented Feb 9, 2022

Describe the bug
Server bans created by import from a room cannot be removed via the !unban command.

To Reproduce
Steps to reproduce the behavior:

  1. Manually modify the ACL of an unprotected room to deny a server.
  2. Tell Mjolnir !import <room> to import the ban from the room
  3. Tell Mjolnir !unban server <server> apply to remove the ban

Expected behavior
The ban is applied and then removed from protected rooms.

Actual behavior
When Mjolnir imports the ban, it creates a state event of type org.matrix.mjolnir.rule.server.
When Mjolnir unbans, it creates an empty state event of type m.room.rule.server. This fails to remove the imported ban.

Additional context
Mjolnir v1.2.1
Synapse v1.52.0

@Gnuxie Gnuxie self-assigned this Feb 15, 2022
Gnuxie added a commit that referenced this issue Feb 21, 2022
* Remove old rules when unbanning entities from BanLists.

Fixes #220
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants