-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use admin api for redactions if possible #538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall lgtm - just a couple of comments on the function placement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
src/utils.ts
Outdated
let redactID: string; | ||
const body = { limit: limit, rooms: targetRooms }; | ||
const redactEndpoint = `/_synapse/admin/v1/user/${userId}/redact`; | ||
const response = await client.doRequest("GET", redactEndpoint, null, body); | ||
redactID = response["redact_id"]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let redactID: string; | |
const body = { limit: limit, rooms: targetRooms }; | |
const redactEndpoint = `/_synapse/admin/v1/user/${userId}/redact`; | |
const response = await client.doRequest("GET", redactEndpoint, null, body); | |
redactID = response["redact_id"]; | |
const body = { limit: limit, rooms: targetRooms }; | |
const redactEndpoint = `/_synapse/admin/v1/user/${userId}/redact`; | |
const response = await client.doRequest("GET", redactEndpoint, null, body); | |
const redactID = response["redact_id"]; |
if it's complaining about types, use response["redact_id"] as string
No description provided.