Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Remove type-ignore for IReactorTCP.connectTCP's hostname argument #10899

Closed
DMRobertson opened this issue Sep 23, 2021 · 3 comments · Fixed by #11939
Closed

Remove type-ignore for IReactorTCP.connectTCP's hostname argument #10899

DMRobertson opened this issue Sep 23, 2021 · 3 comments · Fixed by #11939
Assignees
@clokep
Labels
P4 (OBSOLETE: use S- labels.) Okay backlog: will not schedule, will accept patches S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Milestone
Revisit: Next Qua...

Comments

@DMRobertson
Copy link
Contributor

The fix proposed in #10895 for #10851 requires a series temporary # type: ignore.

We should remove this as soon as we're able: namely, when twisted release a version which includes this commit.
@DMRobertson DMRobertson added this to the Revisit: Next Quarter milestone Sep 23, 2021
@DMRobertson DMRobertson added P4 (OBSOLETE: use S- labels.) Okay backlog: will not schedule, will accept patches S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. labels Sep 23, 2021
DMRobertson pushed a commit that referenced this issue Sep 30, 2021
Pass str to twisted's IReactorTCP (#10895)
2936414 
This follows a correction made in twisted/twisted#1664 and should fix our Twisted Trial CI job.

Until that change is in a twisted release, we'll have to ignore the type
of the `host` argument. I've raised #10899 to remind us to review the
issue in a few months' time.
@DMRobertson DMRobertson added the good first issue Good for newcomers label Oct 18, 2021
@eshaanagarwal
Copy link

hi ! Is this issue open for contribution ?

@DMRobertson
Copy link
Contributor Author

Hi @eshaanagarwal , a contribution would be welcome, but we can't make progress on this until the twisted project makes a new release. I'll remove the good-first-issue label for now to make that a bit clearer.

@DMRobertson DMRobertson removed the good first issue Good for newcomers label Dec 27, 2021
@clokep
Copy link
Member

clokep commented Dec 28, 2021

Note that "new" in this case means a release after 21.7.0 (which is what the current Twisted release is).

@clokep clokep self-assigned this Feb 8, 2022
@clokep clokep mentioned this issue Feb 8, 2022
Merged
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@clokep clokep

Labels
P4 (OBSOLETE: use S- labels.) Okay backlog: will not schedule, will accept patches S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
Revisit: Next Quarter
Development

Successfully merging a pull request may close this issue.

Remove unnecessary ignores due to Twisted upgrade. matrix-org/synapse
4 participants
@callahad @clokep @DMRobertson @eshaanagarwal