Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Update reverse_proxy.md #14739

Closed
wants to merge 2 commits into from
Closed

Update reverse_proxy.md #14739

wants to merge 2 commits into from

Conversation

ankit-pn
Copy link

@ankit-pn ankit-pn commented Dec 28, 2022

In issue #11895, the redirect from /_matrix/client to the URL configured in web_client_location was moved to the root URL (/). This change requires local administrators to update their proxy setups to include the root URL, as the current recommendations only include proxies for /_matrix/ and /_synapse/client/. This is necessary for the new location of the redirect to be effective.

This issue was raised in #14722 by @sumpfralle

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

In issue matrix-org#11895, the redirect from /_matrix/client to the URL configured in web_client_location was moved to the root URL (/). This change requires local administrators to update their proxy setups to include the root URL, as the current recommendations only include proxies for /_matrix/ and /_synapse/client/. This is necessary for the new location of the redirect to be effective.

This issue was raised in matrix-org#14722 by @sumpfralle
@ankit-pn ankit-pn requested a review from a team as a code owner December 28, 2022 10:20
@ankit-pn
Copy link
Author

I am new to this Matrix open source community, and I have requested none to review the code, should I have to ask it manually or it will assigned automatically?

@MatMaul
Copy link
Contributor

MatMaul commented Jan 2, 2023

I am new to this Matrix open source community, and I have requested none to review the code, should I have to ask it manually or it will assigned automatically?

This is fine, we have proper code owners defined so synapse-core has been assigned for review :)

Thanks for your PR, I am unsure about it, and seems like we probably don't want that by default (hence not in the manual), you can find a rationale in the mentioned bug:
#14722 (comment)

@MatMaul
Copy link
Contributor

MatMaul commented Jan 2, 2023

Right I can see that you reacted with a 👍 to this comment, so I am going to close this PR :)

@MatMaul MatMaul closed this Jan 2, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants