Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Implement MSC4069: Inhibit profile propagation #16636

Merged
merged 10 commits into from
Dec 4, 2023

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Nov 15, 2023

MSC: matrix-org/matrix-spec-proposals#4069

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

@turt2live turt2live marked this pull request as ready for review November 15, 2023 02:10
@turt2live turt2live requested a review from a team as a code owner November 15, 2023 02:10
@turt2live
Copy link
Member Author

I'm not sure why sytest is failing here. Feels like a flake.

@clokep
Copy link
Member

clokep commented Nov 15, 2023

I'm not sure why sytest is failing here. Feels like a flake.

matrix-org/sytest#1201

Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sane! I haven't done a full nit-picky review yet. Do you want this to land or are you happy having it as a PR as proof of implementation?

@turt2live
Copy link
Member Author

It would be good to land: it's somewhat blocking implementation of MSCs in matrix-media-repo.

@erikjohnston erikjohnston requested a review from a team November 22, 2023 15:39
Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

Copy link
Member

@erikjohnston erikjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@erikjohnston erikjohnston merged commit d6e194b into develop Dec 4, 2023
@erikjohnston erikjohnston deleted the travis/msc4069-profile-prop branch December 4, 2023 11:36
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants