Error handling and user-agent setting. #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The RegisterEvents method, called from the Connect of the zulip bridge, never checked the HTTP response code from the server; it would blindly assume success and shove the JSON it got into the Queue structure. This meant that matterbridge would happily make repeated requests to the server (see subsequent commits) despite initial registration having failed. Catch non-200 responses, and (when possible) unravel the server-supplied error message within that; return as an err.
Zulip servers respond with 401's if the authentication fails (e.g. a bad token), and 403's if the authenticated user does not have permission to read something. 403's are thus, unlikely to happen for this method of consuming the API, and 401's are far more likely. Include 401 responses in UnauthorizedErrors.
It is good practice for automated bots to identify themselves; the User-Agent format requires both a name and a version. This package does not yet appear to have a concept of release version, so it is arbitrarily set to `1.0-dev`.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference 42wim/matterbridge#1589 -- this is the gozulipbot parts of those changes.