Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Move app history replace to happen only if not in plugin legacy mode #1466

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Move app history replace to happen only if not in plugin legacy mode #1466

merged 2 commits into from
Oct 6, 2021

Conversation

mgdelacroix
Copy link
Contributor

@mgdelacroix mgdelacroix commented Oct 6, 2021 •
edited
Loading

Summary

Removes the history replace for legacy plugin mode, fixing the shared boards URLs in the plugin.

Fixes #1438

@mgdelacroix mgdelacroix added 2: Dev Review Requires review by a core committer 2: QA Review Requires review by a QA tester labels Oct 6, 2021
@mgdelacroix mgdelacroix added this to the v0.9 milestone Oct 6, 2021
@mgdelacroix mgdelacroix marked this pull request as ready for review October 6, 2021 14:15
@mgdelacroix mgdelacroix requested a review from a team as a code owner October 6, 2021 14:15
@mgdelacroix mgdelacroix requested review from ogi-m and removed request for a team October 6, 2021 14:15
@mgdelacroix mgdelacroix added the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Oct 6, 2021
sbishel
sbishel requested changes Oct 6, 2021
View reviewed changes
webapp/src/app.tsx Show resolved Hide resolved
@ogi-m
Copy link
Contributor

ogi-m commented Oct 6, 2021

@mgdelacroix This fixes #1438, but I can still repro the issue that Scott reported - #1392

@mgdelacroix mgdelacroix requested a review from sbishel October 6, 2021 15:47
@mgdelacroix
Copy link
Contributor Author

Thanks @ogi-m! That's solved in a different PR here #1468, which is maybe easier to test once this is merged so both don't collide

As soon as this one is merged I can update the other one so you can test it :)

@ogi-m
Copy link
Contributor

ogi-m commented Oct 6, 2021

Oh great, thanks Miguel!

@ogi-m ogi-m removed the 2: QA Review Requires review by a QA tester label Oct 6, 2021
sbishel
sbishel approved these changes Oct 6, 2021
View reviewed changes
Copy link
Collaborator

@sbishel sbishel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mgdelacroix

@mgdelacroix mgdelacroix merged commit ee3f008 into main Oct 6, 2021
@mattermod
Copy link
Contributor

Error trying doing the automated Cherry picking. Please do this manually

fatal: No such remote 'upstream'

+++ Returning you to the main branch and cleaning up.

@mgdelacroix mgdelacroix deleted the fix-shared-boards-to-board-redirection branch October 6, 2021 15:55
@mattermod
Copy link
Contributor

Cherry pick is scheduled.

@sbishel sbishel added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Dev Review Requires review by a core committer labels Oct 6, 2021
mgdelacroix added a commit that referenced this pull request Oct 6, 2021
@mgdelacroix
Move app history replace to happen only if not in plugin legacy mode (#…
5264b19 
…1466)
@mgdelacroix mgdelacroix removed the CherryPick/Approved Meant for the quality or patch release tracked in the milestone label Oct 6, 2021
@mgdelacroix mgdelacroix added the CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone label Oct 6, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jespino jespino jespino approved these changes

@sbishel sbishel sbishel approved these changes

@ogi-m ogi-m ogi-m approved these changes

@harshilsharma63 harshilsharma63 harshilsharma63 approved these changes

Assignees
No one assigned
Labels
3: Reviews Complete All reviewers have approved the pull request CherryPick/Done Successfully cherry-picked to the quality or patch release tracked in the milestone
Projects
None yet
Milestone
v0.9
Development

Successfully merging this pull request may close these issues.

Bug: /plugins/focalboard gets added to the URL when loading Boards
6 participants
@mgdelacroix @ogi-m @mattermod @jespino @sbishel @harshilsharma63