[MM-55] Update plugin with respect to phase 1 upgrades #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #333 +/- ##
==========================================
+ Coverage 18.41% 18.47% +0.06%
==========================================
Files 9 9
Lines 1515 1510 -5
==========================================
Hits 279 279
+ Misses 1185 1180 -5
Partials 51 51 ☔ View full report in Codecov by Sentry. |
mickmister
approved these changes
Dec 22, 2023
|
|
||
| Use `make dist` to build distributions of the plugin that you can upload to a Mattermost server for testing. | ||
|
|
||
| Use `make check-style` to check the style for the whole plugin. | ||
| This plugin contains both a server and web app portion. Read our documentation about the [Developer Workflow](https://developers.mattermost.com/integrate/plugins/developer-workflow/) and [Developer Setup](https://developers.mattermost.com/integrate/plugins/developer-setup/) for more information about developing and extending plugins. | ||
|
|
| @@ -82,7 +57,7 @@ func findManifest() (*model.Manifest, error) { | |||
| // we don't want to accidentally clobber anything we won't preserve. | |||
| var manifest model.Manifest | |||
| decoder := json.NewDecoder(manifestFile) | |||
| // decoder.DisallowUnknownFields() // Commented out until circleci image is updated: https://github.com/mattermost/mattermost-plugin-zoom/pull/269#discussion_r927075701 | |||
| decoder.DisallowUnknownFields() | |||
Comment on lines
+145
to
+152
| api.On("KVSetWithOptions", "mutex_mmi_bot_ensure", mock.AnythingOfType("[]uint8"), model.PluginKVSetOptions{Atomic: true, OldValue: []uint8(nil), ExpireInSeconds: 15}).Return(true, nil) | ||
| api.On("KVSetWithOptions", "mutex_mmi_bot_ensure", []byte(nil), model.PluginKVSetOptions{ExpireInSeconds: 0}).Return(true, nil) | ||
|
|
||
| api.On("EnsureBotUser", &model.Bot{ | ||
| Username: botUserName, | ||
| DisplayName: botDisplayName, | ||
| Description: botDescription, | ||
| }).Return(botUserID, nil) |
There was a problem hiding this comment.
This changed because we made the code more hardened for race conditions. I wonder why there was no call for EnsureBotUser before the changes in this PR though. I wonder if there is any risk on this
There was a problem hiding this comment.
@mickmister What risk might you be talking about on this?
…ded typescript setup
|
Hi @ayusht2810, can you please resolve the conflicts here? Thank you |
|
@mickmister resolved the conflicts. Please re-review. |
mickmister
approved these changes
Mar 14, 2024
mickmister
added
3: QA Review
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated plugin with respect to phase 1 upgrades
nvmrcfile and updatepackage-lock.jsonfile.Ticket Link