MM-15560 - E2E Fix: update markdown html fixtures

[thekiiingbob]

Summary

• Updated fixtures for the expected HTML output of markdown for the markdown tests.

Ticket Link

JIRA

To run just these tests run npm run cypress:run -- --spec "cypress/integration/markdown/**/*.js" --reporter "spec" --browser "chrome"

[saturninoabril]

Could you please check again? I feel like it's some kind of a valid bug.

[thekiiingbob]

@saturninoabril Should be good now, image proxy for sure impacts this test, so making sure we have it enabled for this test.

[thekiiingbob]

@saturninoabril @migbot Latest changes pushed up. Using cy.route to wait for request to get posts completes before submitting any additional posts.

This should fix an issue @migbot was having.

Right now there are several tests that do the win.fetch = null thing (which causes requests that are fetch to fallback to XHR), which is not entirely ideal, but there is a long awaited open PR to add full network stubbing support - cypress-io/cypress#4176 , which is scheduled after Cypress's 3.3.0 release.

[saturninoabril]

@thekiiingbob I've got test failures on "Markdown - in-line images 3 and 4" due to the pending post ID returned from getLastPostId (see screenshot). I think the previous implementation of "WithRetry" is better suited than the one we have now with hard limit timeout of [30 seconds].(

mattermost-webapp/cypress/support/ui_commands.js

Line 140 in 6ac43f8

cy.get('#postListContent #postContent', {timeout: 30000}).last().parent().as('_lastPost');

)

[thekiiingbob]

@saturninoabril I tested this latest code with caching disabled and under the Fast 3G network conditions, and the markdown tests pass for me. Give it a whirl under your environment and let me know if you are having issues. This should handle all the waiting we need for posts.

Note that the actual implementation really didn't change, but things are passing for me. Image 3 & 4 are definitely the big offenders though. They take the longest to wait for.

[saturninoabril]

Sure, will give it a test. One thing though, the very long timeout, especially 150s seems a flaw to me. Do we have other choice?

[thekiiingbob]

@saturninoabril Added timeouts constants file and started using it. Lemme know if the names of the consants is sufficient and clear enough, or if you had something else in mind. Image related markdown tests are now run after, with more intense timeout requirements added.

[thekiiingbob]

Also, I had to update the expected HTML for the image tests. It seems that the alt attribute is now before the other attributes. If this changes again soon, I'd want to alter how we are doing these tests.

[saturninoabril]

Works for me; all tests passed 💯

[migbot]

All tests passed as well.