Support packed CBOR maps #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
reviewed
Feb 19, 2020
src/codec/cbor.rs
Outdated
Comment on lines
134
to
138
| let j = if self.packed { | ||
| serde_cbor::to_vec(&data)? | ||
| } else { | ||
| serde_cbor::ser::to_vec_packed(&data)? | ||
| }; |
There was a problem hiding this comment.
Did you made a mistake and invert the branches?
|
Only now I came across pyfisch/cbor#173, which made me realise that this feature is not very useful (I can use |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal to add support for "packed" CBOR map keys, as supported by the underlying serde_cbor crate.