go test fails with go1.5

[rovaughn]

I'm curious if this is happening to anyone else.

I built go1.5 from source, bootstrapping with go1.4. When I run go test -short using go1.5, I get the following output.

--- FAIL: TestPreparedStmt (0.00s)
    sqltest.go:287: Query: no such table: t
    sqltest.go:287: Query: no such table: t
    sqltest.go:287: Query: no such table: t
    sqltest.go:287: Query: no such table: t
    sqltest.go:287: Query: no such table: t
    sqltest.go:291: Insert: no such table: t
    sqltest.go:287: Query: no such table: t
    sqltest.go:287: Query: no such table: t
    sqltest.go:287: Query: no such table: t
    sqltest.go:287: Query: no such table: t
PASS
ok      github.com/mattn/go-sqlite3 16.116s

It works fine when I use go1.4 though.

The failing test is in sqlite3_test/sqltest.go. If I remove the concurrency by changing it like so:

278d277
<   ch := make(chan bool)
280,293c279,283
<       go func() {
<           defer func() {
<               ch <- true
<           }()
<           for j := 0; j < 10; j++ {
<               count := 0
<               if err := sel.QueryRow().Scan(&count); err != nil && err != sql.ErrNoRows {
<                   t.Errorf("Query: %v", err)
<                   return
<               }
<               if _, err := ins.Exec(rand.Intn(100)); err != nil {
<                   t.Errorf("Insert: %v", err)
<                   return
<               }

---
>       for j := 0; j < 10; j++ {
>           count := 0
>           if err := sel.QueryRow().Scan(&count); err != nil && err != sql.ErrNoRows {
>               t.Errorf("Query: %v", err)
>               return
295,298c285,289
<       }()
<   }
<   for i := 0; i < nRuns; i++ {
<       <-ch

---
>           if _, err := ins.Exec(rand.Intn(100)); err != nil {
>               t.Errorf("Insert: %v", err)
>               return
>           }
>       }

It works just fine, which implies it's thread safety related. Perhaps https://golang.org/doc/go1.5#runtime could've affected it?

[rovaughn]

I just tried running go test -race -short, but it didn't find any problems.

[mattn]

did you try in latest go-sqlite3?

[siscia]

I do have a very similar problem.

If I run go test -short it works and pass everything, however this code doesn't works:

func CreateVirtualQuestions(vDb *sql.DB) (VirtualQuestions, error) {
    errors := make(chan error)

    var vq VirtualQuestions
    vq.connection = vDb

    go func() {
        rows, err := vDb.Query(`SELECT * FROM questions ORDER BY RANDOM()`)
        if err != nil {
            log.Print("1")
            log.Fatal(err)
            errors <- err
        }
        vq.RandomQuestions = rows
    }()

    go func() {
        rows, err := vDb.Query(`SELECT * FROM questions WHERE faculty = "medicin" ORDER BY RANDOM()`)
        if err != nil {
            log.Print("2")
            log.Fatal(err)
            errors <- err
        }
        vq.RandomMedicin = rows
    }()

    go func() {
        rows, err := vDb.Query(`SELECT * FROM questions WHERE part = "logic" ORDER BY RANDOM()`)
        if err != nil {
            log.Print("3")
            log.Fatal(err)
            errors <- err
        }
        vq.RandomLogic = rows
    }()

    go func() {
        rows, err := vDb.Query(`SELECT * FROM questions WHERE part = "math" ORDER BY RANDOM()`)
        if err != nil {
            log.Print("4")
            log.Fatal(err)
            errors <- err
        }
        vq.RandomMath = rows
    }()

    go func() {
        rows, err := vDb.Query(`SELECT * FROM questions WHERE part = "biology" ORDER BY RANDOM()`)
        if err != nil {
            log.Print("5")
            log.Fatal(err)
            errors <- err
        }
        vq.RandomBiology = rows
    }()

    go func() {
        rows, err := vDb.Query(`SELECT * FROM questions WHERE part = "chemistry" ORDER BY RANDOM()`)
        if err != nil {
            log.Print("6")
            log.Fatal(err)
            errors <- err
        }
        vq.RandomChemistry = rows
    }()

    go func() {
        rows, err := vDb.Query(`SELECT * FROM questions WHERE part = "physic" ORDER BY RANDOM()`)
        if err != nil {
            log.Print("2")
            log.Fatal(err)
            errors <- err
        }
        vq.RandomPhysic = rows
    }()

    return vq, nil
}

each goroutines runs a query and puts the rows in a structure.

$ go version
go version go1.6 linux/amd64

[mattn]

What error did you get on 1.5?

[siscia]

Sorry, I tried only on the 1.6

The error says it doesn't find the table.

[tscholl2]

Are you by chance using an in memory (":memory:") database? If so you should see #204

[siscia]

@tscholl2 yes I am

Thank you :) Fix it :)