Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Distinguish between NULL and zero-length blobs on query #643

Merged
merged 3 commits into from
Nov 21, 2018
Merged

Distinguish between NULL and zero-length blobs on query #643

merged 3 commits into from
Nov 21, 2018

Conversation

akalin
Copy link
Contributor

@akalin akalin commented Sep 22, 2018

Map NULL to nil and non-NULL zero-length blobs to a zero-length byte slice.

This fixes #642.

@akalin
Copy link
Contributor Author

akalin commented Sep 22, 2018

Note that this test failing (and some others) won't show up until #640 is fixed.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 58.344% when pulling ab4f174 on akalin:zero-length-blob into 6de94b0 on mattn:master.

@mattn
Copy link
Owner

mattn commented Sep 24, 2018

@gjrtimmer How do you think this?

@mattn mattn merged commit 873ec57 into mattn:master Nov 21, 2018
@mattn
Copy link
Owner

mattn commented Nov 21, 2018

Thanks

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NULL vs. zero-length blobs are not distinguished on query
3 participants
@akalin @coveralls @mattn