Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix build failure of incorrect expression for unsafe.Sizeof #655

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Fix build failure of incorrect expression for unsafe.Sizeof #655

merged 1 commit into from
Oct 24, 2018

Conversation

typeless
Copy link
Contributor

@typeless typeless commented Oct 24, 2018 •
edited
Loading

Fixes type [1073741824]*[1]uint larger than address space

Emergency fix to make the CI happy again.
Tested on Linux/amd64.

I am still investigating how to test on Windows/386

Much to my surprise, Ubuntu has the package gcc-mingw-w64-i686, which suffices for our purpose.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 58.344% when pulling 576a2cb on typeless:fix-too-large-arrary-error-v2 into 276457a on mattn:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 58.344% when pulling 576a2cb on typeless:fix-too-large-arrary-error-v2 into 276457a on mattn:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 58.344% when pulling 576a2cb on typeless:fix-too-large-arrary-error-v2 into 276457a on mattn:master.

@typeless typeless mentioned this pull request Oct 24, 2018
Closed
@mattn mattn merged commit c7c4067 into mattn:master Oct 24, 2018
@mattn
Copy link
Owner

mattn commented Oct 24, 2018

Thanks.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@typeless @coveralls @mattn