Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix root and example project Makefiles. #27

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Conversation

mattpolzin
Copy link
Owner

@mattpolzin mattpolzin commented Dec 21, 2022

Fixes #26.

  • fix root makefile to substitute correct string when setting the ncurses version.
  • fix example makefiles to pull all local depends and libs.

…es version. fix example makefiles to pull all local depends and libs.
@gallais
Copy link
Contributor

gallais commented Dec 21, 2022

Yep, the pumpkin now works just fine! I do get an error during the build:

cp: cannot stat '../../support/*.dylib': No such file or directory

I suppose we could maybe use cp ../../support/libncurses* ./depends/ncurses-idris-0/lib/ instead of the disjunction?

@mattpolzin
Copy link
Owner Author

mattpolzin commented Dec 21, 2022

I suppose we could maybe use cp ../../support/libncurses* ./depends/ncurses-idris-0/lib/

That should be a good solve. I'm surprised the disjunction errors though. Maybe it prints a message but doesn't technically error out (exit code 1)? The whole point of using || was to do something with a non-zero code rather than give up.

@gallais
Copy link
Contributor

gallais commented Dec 21, 2022

My bad, you're right: it prints the error message but it's not counted as an error.

@gallais gallais mentioned this pull request Dec 21, 2022
@mattpolzin
Copy link
Owner Author

I think I'll merge this & your PR first and come back in one sweep after to change it all over to your idea to clean up the error message.

Thanks for your help in figuring this problem out!

@mattpolzin mattpolzin merged commit cfa2e69 into main Dec 21, 2022
@mattpolzin mattpolzin deleted the fix-some-makefiles branch December 21, 2022 17:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception: (while loading libncurses.so) /lib/x86_64-linux-gnu/libncurses.so: file too short
2 participants