Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix(sample): update references to generateBls12381G2KeyPair #48

Conversation

petermetz
Copy link
Contributor

Signed-off-by: Peter Somogyvari peter.metz@unarin.com

Description

  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) follow conventional commits
  • Documentation has been added / updated (for bug fixes / features)
  • Changes follow the contributing document.

Motivation and Context

The browse sample is not working at the moment because of the earlier breaking change in the API.

Does this PR introduce a breaking change?

  • Yes
  • No

Which merge strategy will you use?

  • Squash
  • Rebase (REVIEW COMMITS)

Signed-off-by: Peter Somogyvari <peter.metz@unarin.com>
@tplooker
Copy link
Member

tplooker commented Sep 8, 2020

@petermetz thanks for the PR appreciate the contribution

Copy link
Member

@tplooker tplooker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@tplooker tplooker merged commit 691fe74 into mattrglobal:master Sep 8, 2020
@petermetz petermetz deleted the fix/sample/generate-bls-12381-g2-keypair branch September 8, 2020 23:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants