-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix(sample/browser): TypeError: Reflect.get called on non-object #49
Comments
Addressed in #48 |
@tplooker Sorry, I may not have been entirely clear here in the description. This issue is not resolved by #48 but is rather unmasked by it. E.g., in my quest to make the sample work, I first encountered the function name issue (which I fixed) and then afterwards I hit the issue described here (and did not immediately know what the cause might be so I just opened this bug). |
Apologies @petermetz thanks for the clarification |
@petermetz on further investigation this issue is being caused by the change in the data type for messages member in the sign request from |
See the latest tests for an example on how to update them |
Fixes mattrglobal#49 Signed-off-by: Peter Somogyvari <peter.metz@unarin.com>
Thanks @tplooker that helped a lot. Sent a PR with the sample fixed in it. |
Fixes #49 Signed-off-by: Peter Somogyvari <peter.metz@unarin.com>
Thanks @petermetz! Appreciate the contribution. |
This locks the sample for bbs-signatures in a browser to be specific to v0.4.0 now re #49
* chore: update samples to work with version 0.4.0 The API changed on the samples from being strings of messages to being Uint8Array of messages. Additionally the type for nonce was changed from string to Uint8Array. This update supports the new API as of v0.4.0 re #50 * docs: updates README.md examples to match v0.4.0 API re #50 * fix: update browser samples to support fixed bbs-signatures v0.4.0 This locks the sample for bbs-signatures in a browser to be specific to v0.4.0 now re #49 Co-authored-by: Tobias Looker <tobias.looker@mattr.global>
To reproduce:
./sample/browser
Chrome Dev Tools Logs:
With Dev Tools "Pause on Exception" this is where it goes sideways:
The text was updated successfully, but these errors were encountered: