-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Swift 5 compatibility #209
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #209 +/- ##
===========================================
- Coverage 99.34% 97.17% -2.18%
===========================================
Files 6 6
Lines 153 389 +236
===========================================
+ Hits 152 378 +226
- Misses 1 11 +10
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## develop #209 +/- ##
===========================================
- Coverage 99.34% 97.17% -2.18%
===========================================
Files 6 6
Lines 153 389 +236
===========================================
+ Hits 152 378 +226
- Misses 1 11 +10
Continue to review full report at Codecov.
|
After wrestling extensively with Travis CI, I finally figured out how to get it to test both Swift 4.2 and Swift 5 with both xcodebuild and CocoaPods. This PR will be merged as part of #215. Thank you so much for your work on this! |
You're welcome, and thanks for merging the PR. Do you plan to release this to the cocoapods mater repo soon? |
@gereons OneTimePassword 3.2.0 has been pushed to the CocoaPods trunk! Please let me know if you have any issues upgrading. |
Add Swift 5 compatibility. The podspec declares compatibility with both the 4.2 and the 5.0 compiler via the new
swift_versions
directive which is available as of cocoapods v1.7.0.Fixes #207