Rollback PDL to stable and update fetcher to match #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
approved these changes
Oct 24, 2024
Comment on lines
+3
to
+4
| // Check if the chosen revision has a build available for all platforms. | ||
| // That not always the case, that is why we need to make sure of it. |
Comment on lines
+6
to
23
| // The chromium revision is hard to get right and the relation to the CDP revision | ||
| // even more so, so here are some guidances. | ||
| // | ||
| // We used to use the revision of Puppeteer, but they switched to chrome-for-testing. | ||
| // This means we have to check things ourself. The chromium revision should at least | ||
| // as great as the CDP revision otherwise they won't be compatible. | ||
| // Not all revisions of chromium have builds for all platforms. | ||
| // | ||
| // This is essentially a bruteforce process. You can use the test `find_revision_available` | ||
| // to find a revision that is available for all platforms. We recommend setting the `min` | ||
| // to the current CDP revision and the max to max revision of stable chromium. | ||
| // See https://chromiumdash.appspot.com/releases for the latest stable revision. | ||
| // | ||
| // In general, we should also try to ship as close as a stable version of chromium if possible. | ||
| // The CDP should also be a bit older than that stable version. | ||
| // To map a revision to a chromium version you can use the site https://chromiumdash.appspot.com/commits. | ||
|
|
||
| /// Currently downloaded chromium revision |
|
I will do a rewrite tomorrow and some testing. If you can do a pass same time tomorrow everything should be ready. |
|
To me it seems like chrome-for-testing would be the most useful version to most users - specially since puppeteer switched to it. Is there any reason chrome-for-testing can't be used by default? Licensing? Thanks |
|
@GUIpsp There is no reason in particular, I just wrote the fetcher before it was a thing. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Couple of important changes: