Implemented FITS header reader and added quotation marks in CMakeLists #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, add a title to the table window |
|
Could you please add your |
matwey
requested changes
Nov 6, 2018
matwey
reviewed
Nov 14, 2018
src/mainwindow.cpp
Outdated
| @@ -264,7 +264,7 @@ void MainWindow::setState(std::unique_ptr<MainWindowState>&& new_state) { | |||
| } | |||
|
|
|||
| void MainWindow::openFileHere() { | |||
| const auto filename = QFileDialog::getOpenFileName(this, tr("Open FITS file in current window")); | |||
| const auto filename = QFileDialog::getOpenFileName(this, tr("Open FITS file in current window"), tr(""), tr("*.fits;*.fit")); | |||
There was a problem hiding this comment.
Could you please put this into separate commit?
There was a problem hiding this comment.
Please, provide an option to show and select all files, some FITS files may have different extension.
aalexr
force-pushed
the
master
branch
3 times, most recently
from
35a63dd to
f1ddda1
Compare
matwey
requested changes
Nov 23, 2018
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check this GUI features before merge:
BITPIXimages