Builds on and supersedes #39 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This usage cannot be inferred, as it calls the trait function at an undefined point in time. It is incorrect and invalid to treat `generated` as a pure annotation. Instead, assume that the user will provide inferrably-pure functions as traits.
Also fixed an bug with IsNothing
Aside, here all the related issues: - #39 - #40 - JuliaLang/julia#21356
|
I cannot reproduce the test errors locally, nor does it show up on AppVeyor. The test error is that the trait functions on travis produce longer llvm-ir than their non-traits counterparts (20 lines vs 8 lines). I'll try to track down the cause, but for now I'm out of time. If anyone finds the time to look at this on their local machine and sees the same test-failure, please let me know. |
|
The test isn't valid to run with code-coverage enabled (we can't both elide the code entirely, and record that it was run). |
|
Thanks @vtjnash: that's it! It would probably have taken me hours... |
mauro3
force-pushed
the
m3/generated-fix
branch
from
29383b6 to
1d5f7a6
Compare
mauro3
force-pushed
the
m3/generated-fix
branch
from
1d5f7a6 to
80f13e0
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on and supersedes #39.