fix power level assignment for non-double-puppeted users, some cleanup #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maltee1
force-pushed
the
fix_user_power_level
branch
from
1c86c48 to
ce4af2b
Compare
…double-puppeted users
maltee1
force-pushed
the
fix_user_power_level
branch
from
ce4af2b to
4c91dc8
Compare
tulir
approved these changes
Jan 28, 2023
Comment on lines
+2347
to
+2349
| if not info: | ||
| self.log.debug(f"No info provided for updating power levels in {self.mxid}") | ||
| return |
There was a problem hiding this comment.
Returning None from here is not allowed, but the case seems pointless anyway since info is always provided.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting a puppet for a double-puppeted user returns the user, if double puppeting is not enabled, it will only return their puppet. This caused non-double-puppeted users to not receive appropriate power level for their account.
This PR also cleans up a few loosely related things: