Fixing squid:S1066--Collapsible "if" statements should be merged #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, thanks! But please watch the whitespace. It looks like these updates do not preserve the NAR convention of two spaces. If you are using Eclipse, you can import the NAR code formatting rules before proceeding. Can you please rewrite this commit with the proper formatting? Then I will merge it! |
|
Since the whitespace violations are minor, I am merging this as-is. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is focused on resolving occurrences of Sonar rule "squid:S1066 - , Collapsible "if" statements should be merged" information about the issues here:
https://dev.eclipse.org/sonar/rules/show/squid:S1066
Please let me know if you have any questions.
Sameer Misger