Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add parameters for frame_id of static transforms for multi-vehicle systems #1967

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

EnderMandS
Copy link

Similar to another PR at branch-ros2, this PR solves the problem of static transforms namespace conflicts in multi-vehicle systems by adding parameters. Also dealt with a similar issue with the lookup_static_transform function in the odometry plugin.

Users can modify the frame_id by adding the following parameter to the launch file :

<param name="base_link_frame_id" value="$(arg base_link_frame_id)" />
<param name="odom_frame_id" value="$(arg odom_frame_id)" />
<param name="map_frame_id" value="$(arg map_frame_id)" />

While changing the launch file also change the corresponding frame_id section in the px4_config.yaml file :

# odom example
odometry:
  fcu:  # change frame_id to vehicle_0/...
    map_id_des: "vehicle_0/map"    # desired parent frame rotation of the FCU's odometry
    odom_child_id_des: "vehicle_0/base_link"    # desired child frame rotation of the FCU's odometry
    odom_parent_id_des: "vehicle_0/odom"

Copy link
Member

@vooon vooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@vooon vooon added this to the Version 1.20 milestone Jul 16, 2024
@vooon vooon merged commit 82784b8 into mavlink:master Jul 16, 2024
3 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants