Menu positioning not correct on different taskbar positions on Windows

[vkolova]

Description

Positioning of menu window is incorrect on Windows when you change taskbar position.

Steps to Reproduce the Problem

1. Add menubar
2. Change taskbar position

Expected Behaviour

Actual Behaviour

top
left
right

Specifications

• Menubar version: 6.1.0
• Platform: Windows 10
• Electron version: 5.0.1

[amaury1093]

Agreed, reproduced. Since I think changing taskbar position is not a frequent operation, I consider this issue a lower-priority.

If anyone wants to work on this, feel free to open a PR!

[thomasdarde]

Hello

It's not perfect but this was wat I did put in place

mb.on("show", function() {
    if(process.platform === 'win32'){
      var trayBounds = mb._tray.getBounds()
      var windowPosition = "trayBottomCenter"
      if(trayBounds.width === trayBounds.height && trayBounds.x < trayBounds.y) {
        log.info("Tray is on left side")
        windowPosition = "center"
      }
      // Force right place for the window
      // On launch it can show beside the menubar
      mb.setOption("windowPosition", windowPosition)
    }
  })

[RobbieTheWagner]

@thomasdarde does that work for both left positioned taskbars and the normal bottom position? If so, is this something we could incorporate into the library?

[thomasdarde]

it does, feel free to reuse this code

[RobbieTheWagner]

@thomasdarde would you perhaps be able to open a PR? This was the most recently merged one for Windows placement https://github.com/maxogden/menubar/pull/307/files. Perhaps you could use that as reference for where to put in your solution?

[thomasdarde]

sorry it's a long time since I did update this code and I'm quite busy now