Ndarray #18
Merged
Ndarray #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2014
…inates Fixes setBlock() etc. in voxel-engine. Removed the index calculation since it is now handled by ndarray.
|
Rebased, cleaned up commit history |
Accounts for padding along the edges of the chunk Requires deathcap/voxel-engine@216be65
|
+1 on this, can we merge this? |
|
I see no reason not to, needed for max-mapper/voxel-engine#103 |
deathcap
added a commit
that referenced
this pull request
Feb 11, 2015
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts to use ndarray for the voxel format. This is independent of gl-now integration, but any chunk generators would have to update (not backwards-compatible. example update in voxel/voxel-land@c01750c). feedback welcome
(note:
meshers/are not needed for the gl-modules port (meshing implemented instead in voxel-mesher), but I left them in for three.js-based voxel-engine compatibility)ref voxel/issues#4 ndarray/gl-now integration