Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Make GIST_ID as a secret #112

Merged
merged 2 commits into from
Feb 16, 2024
Merged

Make GIST_ID as a secret #112

merged 2 commits into from
Feb 16, 2024

Conversation

AlexV525
Copy link
Contributor

@AlexV525 AlexV525 commented Jan 7, 2024

Users can write GIST_ID in secrets to avoid further modification to files and related commits, which helps for future upstream merges.

@AlexV525
Copy link
Contributor Author

AlexV525 commented Jan 7, 2024

(Use squash to merge can avoid non-linear commit history)

@maxam2017
Copy link
Owner

maxam2017 commented Feb 16, 2024

How about using Repository Variables? gist id can store plain text.
Additionally, we can move the timezone into a variable too, so users don't need to push any commit.

ref. https://docs.github.com/en/actions/learn-github-actions/variables

Copy link
Owner

@maxam2017 maxam2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the active fork also includes the Gist ID in the secret. I believe this is acceptable.

@maxam2017 maxam2017 merged commit 2ceb591 into maxam2017:master Feb 16, 2024
ickynavigator pushed a commit to ickynavigator/productive-box that referenced this pull request May 19, 2024
* Update schedule.yml

* Update README.md
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants