Insert from file #109
Merged
Insert from file #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Btw thanks for the contribution! Very useful method. |
|
@maximdanilchenko should i change something so that you merge this PR? |
aiochclient/client.py
Outdated
| async def insert_file( | ||
| self, | ||
| query: str, | ||
| filepath: str, |
There was a problem hiding this comment.
What about making it not a path str, but a file obj to make it possible to use it for instance in web servers when someone want to get file by web?
There was a problem hiding this comment.
I made updates and now method has file_obj param
|
Sorry, made a comment, but forgot to submit review |
maximdanilchenko
approved these changes
Jan 9, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.