fix path of SQLITE_URL for Django (postorius + web docker-image) #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Startup of images using SQLite database fails as of non-existent database file. Fix this by using the proper syntax [1] to have the database created at /opt/mailman-web-data/mailmanweb.db 1 - joke2k/django-environ#187 (comment) Signed-off-by: Sven Roederer <sven@geroedel.de>
Closed
|
We don’t use django-environ in this project and also the syntax is actually correct, it will just create the database in the CWD which is /opt/mailman-web inside the container. The only issue really is that it won’t persist container upgrades since it is not a mount point. Although, they are different database engines. Does this change in this allow your local setup to work correctly? If yes, I’ll go ahead and merge this. |
|
This Pull Request has not been updated for more than 1year |
|
Sorry for the long delay ... As far as I remember, with this change included the setup passed without issues. |
|
Thanks! Merging this. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Startup of images using SQLite database fails as of non-existent database file.
Fix this by using the proper syntax (joke2k/django-environ#187 (comment)) to have the database created at /opt/mailman-web-data/mailmanweb.db .
Addresses the problem of #193 I also ran into.