Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Refresh golangci-lint config #111

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Refresh golangci-lint config #111

merged 3 commits into from
Feb 18, 2025

Conversation

oschwald
Copy link
Member

  • Test on 1.24
  • Refresh golangci-lint config and convert to YAML

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

Modver result

This report was generated by Modver,
a Go package and command that helps you obey semantic versioning rules in your Go module.

This PR does not require a change in your module’s version number.
(You might still consider bumping the patchlevel anyway.)

horgh
horgh requested changes Feb 18, 2025
View reviewed changes
.golangci.yml Outdated
- os.Remove
- os.RemoveAll

# This is a workaround for https://github.com/golangci/golangci-lint/issues/4733
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to remove this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I remove it.

@horgh horgh merged commit f0813fd into main Feb 18, 2025
10 checks passed
@horgh horgh deleted the greg/eng-1287 branch February 18, 2025 23:06
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@horgh horgh horgh approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oschwald @horgh