Bug fixes from swiping #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for removeEventListener('hardwareBackPress') when swipe to close
|
Thanks @TheNerdGuyLulu |
|
Thanks @TheNerdGuyLulu. @maxs15 when can I expect a new release with this fix in? |
|
I want to check everything, to be sure it doesn't introduce other bugs. |
|
Sounds great, thanks @maxs15 ! |
|
Released in v2.0.0 ! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for:
Preventing swipe from getting stuck when swipeThreshold position not reached;
Set the state to the starting position of the modal, preventing animating from where the swipe stopped;
Remove event listener for back button when swipe to close