Add vite-plugin-glsl to support GLSL external shader files and add de… #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…claration file to help Typescript to resolve shader import
mayacoda
reviewed
Jul 4, 2022
| version "0.141.0" | ||
| resolved "https://registry.yarnpkg.com/@types/three/-/three-0.141.0.tgz#d9d81a54b28ebc2a56931dfd4d9c54d25c20d6c8" | ||
| integrity sha512-OJdKDgTPVBUgc+s74DYoy4aLznbFFC38Xm4ElmU1YwGNgR7GGFVvFCX7lpVgOsT6S1zSJtGdajTsOYE8/xY9nA== | ||
| "integrity" "sha512-OJdKDgTPVBUgc+s74DYoy4aLznbFFC38Xm4ElmU1YwGNgR7GGFVvFCX7lpVgOsT6S1zSJtGdajTsOYE8/xY9nA==" |
There was a problem hiding this comment.
Ouch, this formatting diff is probably caused by different yarn versions. I should specify which one the project uses, and also upgrade my own 😅
I'll do that and update the yarn.lock before this merges so that the diff is clearer.
| import { defineConfig } from "vite"; | ||
|
|
||
| export default defineConfig({ | ||
| plugins: [glsl.default()] //For some reason, cannot resolve glsl(). Workaround found on vite-plugin-glsl issue (https://github.com/UstymUkhman/vite-plugin-glsl/issues/1#issuecomment-972660771) |
There was a problem hiding this comment.
Thanks for leaving a comment about this! 🙌
There was a problem hiding this comment.
I think the reason for this might be this line. It forces all JS files to be loaded as ES6 Modules, but video-glsl-plugin compiles to CommonJS, that's why you need to use it as glsl.default(). Since this seems to be a front-end project, I don't think you really need that line in package.json. More info here.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…claration file to help Typescript to resolve shader import
vite.config.jsto configurate the project.glsl.default()in the config file.glsl()was not found by Vite while trying the documentation configuration. The workaround is described in the following issue of vite-plugin-glslglsl.d.tsadded to the shaders folder I created to help Typescript to resolve the import (see this post for reference).vertex.glslandfragment.glsladded to provide an example that this is working.Resolves #1