Skip to content

Code coverage of tests should be 100% #96

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
xalopp opened this issue Sep 13, 2018 · 2 comments
Closed

Code coverage of tests should be 100% #96

xalopp opened this issue Sep 13, 2018 · 2 comments

Comments

@xalopp
Copy link
Contributor

xalopp commented Sep 13, 2018

To increase confidence, we should look to have a code coverage of 💯
@Ma27
Copy link
Contributor

Ma27 commented Sep 13, 2018

sounds reasonable. But I'm not sure if entirely convinced about this as I remember some PHPUnit-related issues where i.e. a closing bracket was untested code, so I couldn't reach 100% coverage in some side-projects back then. But please correct me if I'm wrong, I didn't do too much PHP in the last year 😄

@mmoll
Copy link
Contributor

mmoll commented Sep 13, 2018

I did have a look into the coverage HTML report and IIRC there is indeed one line (or condition?) that's currently not tested.

xalopp added a commit to xalopp/mo4-coding-standard that referenced this issue Oct 19, 2018
@xalopp
fix no multiline comments after declarations, fixes mayflower#96
b367697
xalopp added a commit to xalopp/mo4-coding-standard that referenced this issue Oct 19, 2018
@xalopp
fix no multiline comments after declarations, fixes mayflower#96
444f498
@mmoll mmoll closed this as completed in d1d9864 Oct 22, 2018
mmoll pushed a commit to mmoll/mo4-coding-standard that referenced this issue Oct 23, 2018
@xalopp @mmoll
fix no multiline comments after declarations, fixes mayflower#96
409cfad 
(cherry picked from commit d1d9864)
xalopp added a commit that referenced this issue Oct 24, 2018
@xalopp
fix no multiline comments after declarations, fixes #96
7c39d10 
(cherry picked from commit d1d9864)
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mmoll @xalopp @Ma27