Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

builder/AmazonChroot add conditional prop validation when from_scratch used #126

Closed
mayn opened this issue Oct 1, 2018 · 2 comments
Closed

Comments

@mayn
Copy link
Owner

mayn commented Oct 1, 2018

packer v1.3.1 feature sync
see: https://www.packer.io/docs/builders/amazon-chroot.html#from_scratch

add attribute to https://github.com/mayn/packerlicious/blob/master/src/packerlicious/builder.py#L260

@mayn mayn added this to the 1.1.0 milestone Oct 1, 2018
@mayn mayn changed the title add support for builders/amazon-chroot#from_scratch builder/AmazonChroot add prop from_scratch Oct 1, 2018
@isaacm
Copy link
Contributor

isaacm commented Oct 1, 2018

The from_scratch attribute is already in the class AmazonChroot what else is missing to complete this ticket? validation of the additional required attributes when from_scratch is set to True?

If true, source_ami is no longer used and the following options become required: ami_virtualization_type, pre_mount_commands and root_volume_size.

@mayn
Copy link
Owner Author

mayn commented Oct 2, 2018

@isaacm good catch, this is oversite on my part.
feel free to move onto another tix. The additional conditional validation would be a welcomed addition though.

@mayn mayn closed this as completed in #130 Oct 4, 2018
@mayn mayn changed the title builder/AmazonChroot add prop from_scratch builder/AmazonChroot add conditional prop validation when from_scratch used Oct 4, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants