Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

AmazonChroot: validate required options when from_scratch is true #130

Merged
merged 1 commit into from
Oct 4, 2018
Merged

AmazonChroot: validate required options when from_scratch is true #130

merged 1 commit into from
Oct 4, 2018

Conversation

isaacm
Copy link
Contributor

@isaacm isaacm commented Oct 2, 2018

Issue

Fixes #126.

List of Changes Proposed

Add validation for required options when from_scratch option is set to True.

Testing Evidence

See added unit tests.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling def0d8f on isaacm:validate-chroot-from-scratch-option into f3793b8 on mayn:master.

@mayn mayn added this to the 1.0.2 milestone Oct 4, 2018
@mayn mayn merged commit 8e1441f into mayn:master Oct 4, 2018
@mayn mayn modified the milestones: 1.0.2, 1.1.0 Oct 13, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@mayn mayn mayn approved these changes

Assignees
No one assigned
Labels
builder enhancement Hacktoberfest
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@isaacm @coveralls @mayn